trinity-users@lists.pearsoncomputing.net

Message: previous - next
Month: July 2013

Re: [trinity-users] 3.5.13.2 coming soon

From: "Timothy Pearson" <kb9vqf@...>
Date: Mon, 1 Jul 2013 17:53:09 -0500
> On Sunday 30 of June 2013 17:20:47 Andy wrote:
>> On Sunday 30 June 2013 10:47:54 am Sl√°vek Banko wrote:
>> > On Monday 10 of June 2013 09:18:15 Timothy Pearson wrote:
>> > > You can try using the automated conversion script here:
>> > > http://git.trinitydesktop.org/cgit/experimental/tree/qt3-tqt3/convert_e
>> > >xisting_qt3_app_to_tqt3
>> > >
>> > > Be warned that it takes a LOT of CPU time to run, and that the
>> result
>> > > probably won't compile the first time around.  However, it will deal
>> > > with 99% of the tedious renaming without intervention.
>> > >
>> > > You then need to take into account the more recent TDE header file
>> and
>> > > class name changes.  Unfortunately, I do not have a script to
>> > > automatically convert a project to use the new TDE class names and
>> > > header files, so you would need to make those changes by hand or via
>> > > your own scripts.
>> > >
>> > > How I typically handle import of a new application is I first commit
>> > > the last known working version of the application from the original
>> > > source (i.e. the original project website) to a new GIT repository.
>> I
>> > > then apply and commit all changes needed to get it building on Qt3
>> with
>> > > TDE 3.5.13.x, then finally run the autoconversion tools and commit
>> the
>> > > first working version for TDE R14.  This keeps the original versions
>> > > around in the GIT history in case something broke during build fixes
>> > > and/or R14 conversion and is not noticed until far in the future
>> (this
>> > > has happened many times before!)
>> > >
>> > > Tim
>> >
>> > Because my home machine is pretty slow, I noticed a high demands of
>> > script. On one smaller test project ran over 24 minutes.
>> >
>> > I've done in this script some optimizations:
>> >
>> > 1) Instead of starting sed using "find -exec sed" I used the "find |
>> > xargs sed". With xargs not run sed for each file, but one sed for
>> > multiple files.
>> >
>> > 2) Instead of starting sed for each replacement I'm using "-e" amassed
>> > more replacements to the single sed.
>> >
>> > After this optimizations on the same small test project I'm got the
>> same
>> > result in 2.5 minutes. Updated script pushed to git in hash 5fc3ba9a.
>> >
>> > Slavek
>>
>> +1!  Teamwork, it's great!
>>
>> Andy
>>
>
> During testing, the success of the conversion, I noticed a significant
> problem - Q_OBJECT is renamed to TQ_OBJECT. And consequently fails
> building
> MOC files - more precisely, they are not builded, and this leads to FTBFS.
>
> It is either unwanted rename, or should be the same renaming done
> throughout
> whole GIT tree, including the admin module in order to properly work
> generating MOC files.
>
> Tim, please, what is the correct way?
>
> Thanks
> Slavek
> --

Use Q_OBJECT.  Eventually we might need to change to TQ_OBJECT, but I
don't want to make that large of a change in the R14 soft freeze. ;-)

Tim